Document that pool config updates skip acquired browsers#430
Closed
masnwilliams wants to merge 1 commit into
Closed
Document that pool config updates skip acquired browsers#430masnwilliams wants to merge 1 commit into
masnwilliams wants to merge 1 commit into
Conversation
Clarify in the pools overview and FAQ that update() only applies to idle browsers; an acquired browser released with reuse: true returns to the pool on its original config until it cycles out. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Contributor
Author
|
Closing in favor of #431, which covers the same behavior with a stronger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
browserPools.update()only reconfigures idle browsers — a browser that's acquired at update time keeps its original config, and releasing it withreuse: truereturns it to the pool still on the old config until it cycles out.<Note>to the "Update a pool" section of the pools overview covering the same acquired-browser behavior, next to the existingdiscard_all_idleexplanation.Why
The idle-browser update behavior (
discard_all_idle, flush) is already documented, but the consequence for acquired browsers released withreuse: truewasn't called out anywhere. This is a real gotcha: a pool can hold a mix of old- and new-config browsers after an update until the acquired ones drain. The docs now spell out the two ways to force a clean cutover (reuse: falseor letting them time out).Test plan
<Note>component + FAQ formatting).